Fix for TestTLSConfig/update_key_file_with_an_invalid_key_start_error_log_loop #6533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or_log_loop in diskcertmanager package. The previous fix in spiffe#6528 removed Eventually assuming synchronous execution with the mock clock, but the goroutine processing ticker events needs real wall-clock time to write log entries after clk.Add() returns, causing intermittent failures when assertions ran before logs appeared. Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
requested review from
MarcosDY,
evan2645,
rturner3 and
sorindumitru
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in a recent run (https://github.com/spiffe/spire/actions/runs/20684724898/job/59383543125?pr=6532#step:5:417) that
TestTLSConfig/update_key_file_with_an_invalid_key_start_error_log_loopfailed again.PR #6528 removed
Eventuallyassuming the goroutine would complete synchronously afterclk.Add(), but the goroutine needs to be scheduled by the Go runtime to process the ticker events and write log entries, causing the test to fail when assertions ran before the goroutine finished its work.This PR adds back
Eventuallyonly where needed to wait for asynchronous goroutine execution.