Skip to content

Conversation

@amartinezfayo
Copy link
Member

@amartinezfayo amartinezfayo commented Jan 3, 2026

Update k8s.io dependencies to v0.35.0.

Replace deprecated fake.NewSimpleClientset() with fake.NewClientset() in k8sbundle tests, which adds field management support for improved server-side apply testing.

Updated test assertions to use cmp.Diff with cmpopts.IgnoreFields to ignore the TypeMeta and ManagedFields metadata populated by the new clientset.

The aggregator fake client still uses NewSimpleClientset() with a nolint directive since the aggregator package doesn't provide NewClientset until apply configurations are generated. Created #6530 to track this.

This PR supersedes #6498.

Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Copy link
Collaborator

@sorindumitru sorindumitru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I opened kubernetes/kubernetes#135980 last week for this. Looks like there's an open PR for it now so maybe we'll get the non-deprecated version soon.

@amartinezfayo amartinezfayo merged commit 52a2d7b into spiffe:main Jan 5, 2026
49 checks passed
@amartinezfayo amartinezfayo added this to the 1.14.1 milestone Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants