Add support for minting WIT-SVIDs #6517
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
force-pushed
the
wit-sign
branch
2 times, most recently
from
aef8c43 to
aa9d8cb
Compare
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
sorindumitru
requested review from
MarcosDY,
amartinezfayo,
evan2645 and
rturner3
as code owners
pkg/server/api/svid/v1/service.go
Outdated
| PublicKey: jose.JSONWebKey{ | ||
| Key: publicKey, | ||
| }, | ||
| // TODO: add its own TTL |
Member
There was a problem hiding this comment.
It would be good to mention https://github.com/spiffe/go-spiffe/issues/373 here.
|
|
||
| for format in pretty json; do | ||
| for keyType in ec-p256 ec-p384 rsa-2048 rsa-4096; do | ||
| docker compose exec -T spire-server /opt//spire/bin/spire-server \ |
Member
There was a problem hiding this comment.
Suggested change
| docker compose exec -T spire-server /opt//spire/bin/spire-server \ | |
| docker compose exec -T spire-server /opt/spire/bin/spire-server \ |
| done | ||
|
|
||
| # Check that we can specify a custom TTL | ||
| docker compose exec -T spire-server /opt//spire/bin/spire-server \ |
Member
There was a problem hiding this comment.
Suggested change
| docker compose exec -T spire-server /opt//spire/bin/spire-server \ | |
| docker compose exec -T spire-server /opt/spire/bin/spire-server \ |
| wit mint -spiffeID "spiffe://domain.test/workload" -ttl 60s || fail-now "could not mint WIT-SVID with custom TTL" | ||
|
|
||
| # Check that WIT-SVID can be written to a directory | ||
| docker compose exec -T spire-server /opt//spire/bin/spire-server \ |
Member
There was a problem hiding this comment.
Suggested change
| docker compose exec -T spire-server /opt//spire/bin/spire-server \ | |
| docker compose exec -T spire-server /opt/spire/bin/spire-server \ |
cmd/spire-server/cli/cli.go
Outdated
| "jwt mint": func() (cli.Command, error) { | ||
| return jwt.NewMintCommand(), nil | ||
| }, | ||
| "wit mint": func() (cli.Command, error) { |
Member
There was a problem hiding this comment.
I think that we should only expose wit commands if the feature flag is enabled.
It's unfortunate that we can't use the fflag package at this point, because fflags are not loaded until we load the config in Run.
You can refer to https://github.com/spiffe/spire/pull/5586/changes#diff-f06b238782ee9be14f22b6719b32075f5a2ec8c96fe6d2fd4885e74326d98d05L146 for an example of how we implemented this when we had the force rotation work in progress. We should probably have a better solution for this.
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
amartinezfayo
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This adds support in spire-server for minting WIT-SVIDs using the MintWITSVID API. The BatchNewWITSVID APIs are also implemented, but are currently unused.
Which issue this PR fixes
fixes #6374