Update azure sdk libraries #6494
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikotih
requested review from
MarcosDY,
amartinezfayo,
evan2645,
rturner3 and
sorindumitru
as code owners
nikotih
force-pushed
the
Update-azure-sdk
branch
from
b25a1f5 to
c83973a
Compare
Signed-off-by: Nikolai Tihhomirov <141064611+nikotih@users.noreply.github.com>
nikotih
force-pushed
the
Update-azure-sdk
branch
from
c83973a to
bbceeca
Compare
Member
amartinezfayo
left a comment
amartinezfayo
left a comment
There was a problem hiding this comment.
Thank you @nikotih for noticing this and providing a fix.
I also think that it would be prudent to include this update in a minor release.
I've added this PR to the 1.15.0 milestone.
Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Description of change
Our scanner noticed old azure sdk lib usage.
NOTE: we dont use those plugins. i've upgraded to the best of my understanding and consulting
https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/security/keyvault/azkeys/CHANGELOG.md
Might be good idea to gate it behind minor release
Which issue this PR fixes