release candidate #282
Open
release candidate #282
+1,631
−3,676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add context.Context parameter to all SDK API calls to enable proper request cancellation and timeout handling. This replaces the previous workaround in dispatch.go that wrapped calls in goroutines. Key changes: - All API method calls now accept context as first parameter - Remove contributeWithContext wrapper in favor of native SDK support - Move cipher helper functions (readAndGuardRequest, getCipherAndEncrypt, respond* functions) to SDK net package - Use AuthorizeAndRespondOnFailForPath for path-based authorization - Delete unused cipher state, net, and read files now handled by SDK - Remove toSecretMetadataSuccessResponse in favor of SDK's ValueToSecretMetadataSuccessResponse Signed-off-by: Volkan Özçelik <me@volkan.io>
Move defer cleanupIn() before error check to satisfy linter. The openInput function returns a no-op cleanup on error, so calling it unconditionally is safe and more defensive. Also fix indentation in encrypt_impl.go and delete.go. Signed-off-by: Volkan Özçelik <me@volkan.io>
Signed-off-by: Volkan Özçelik <me@volkan.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
placeholder PR for the next release.
other outstanding PRs will be staged to be done after the release cut.