Remove mentions of the k8s_sat node attestor #326
Conversation
sorindumitru
requested review from
Andres-GC,
ajessup,
evan2645,
mchurichi,
sanderson042 and
umairmkhan
as code owners
✅ Deploy Preview for spiffe ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sorindumitru
force-pushed
the
k8s-psat
branch
from
f94a4d6 to
8019e6f
Compare
sorindumitru
force-pushed
the
k8s-psat
branch
2 times, most recently
from
f8175f6 to
ede86d9
Compare
sanderson042
left a comment
sanderson042
left a comment
There was a problem hiding this comment.
Is the term "Service Account Token" still ok to use as a general term or should those all now be "Projected Service Account Token"? Just in case, I've listed some cases where "Service Account Token" is used.
configuring.md:
Line 68
spire-about/spire-concepts.md:
line 144
line 172
line 189
Thanks again for the review. I think these should be ok, both PSAT and SATs are service account tokens, I think it's more about how they are delivered to the application. The Projected kind allows for shorter lifetimes. Happy to changes those to say "projected service accounts", but I think there shouldn't be any confusion as they are. |
sanderson042
left a comment
sanderson042
left a comment
There was a problem hiding this comment.
Hi Sorin, thanks for responding to my question about existing uses of "service account tokens." Your recommendation to leave the existing text as-is seems fine. I'm approving this PR.
|
It would be great to get this PR merged because the docs on spiffe.io don't work with spire-tutorials/k8s/quickstart. |
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
We now have the helm charts documented on the site, they are going to be a much better choice for production. Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
|
Thanks @donaldh for reminding me about this, I forgot it didn't get merged |
4 participants
Description of the change
The k8s_sat node attestor has been deprecated for a few releases and will be removed in 1.12.0. This remove the usage of it found in on spiffe.io.
This should only be merged after spiffe/spire-tutorials#140 gets merged.
Which issue this PR fixes
fixes #325