fix: quote args in fish shell completion #2285
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ccoVeille
reviewed
Jun 11, 2025
The arguments used for dynamic completions in fish were missing quotes. This resulted in an error when one of the arguments had a `*` in it whose expansion matched no file. Once the completion got triggered, fish errored with the message `No matches for wildcard [...]`. Don't quote the first argument as that is the name of the binary.
n9v9
force-pushed
the
issue-1933/quote-fish-args
branch
from
5eac3d8 to
69ce136
Compare
ccoVeille
approved these changes
Jun 11, 2025
Collaborator
|
This seemed reasonable but when I run the tests in https://github.com/marckhouzam/cobra-completion-testing I'm getting failures. I haven't investigated yet. |
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
Collaborator
|
I pushed a commit on top of the PR to properly handle when the arguments are flags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments used for dynamic completions in fish were missing quotes. This resulted in an error when one of the arguments had a
*in it whose expansion matched no file. Once the completion got triggered, fish errored with the messageNo matches for wildcard [...]. Don't quote the first argument as that is the name of the binary.Closes #1933