-
Notifications
You must be signed in to change notification settings - Fork 130
Fix CI and README typos #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
marckhouzam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
I haven’t looked at the cobra-cli in a very long time. CI seems to be broken |
|
Hi @marckhouzam , I've aligned |
|
Now the tests themselves are failing. See https://github.com/jessp01/cobra-cli/actions/runs/13499877160/job/37715453667#step:6:75 |
`golangci/golangci-lint-action` versions
|
All CI issues are now fixed: https://github.com/jessp01/cobra-cli/actions/runs/13500614133 |
|
Hi @marckhouzam , Did you get a chance to review the CI fixes I applied? Don't mean to rush you, of course, just thought I'd tag you to make sure you're aware. |
|
Hi @marckhouzam , Just following up on this. Cheers, |
gocriticfindings:bytes.Replace(content, []byte("\r\n"), []byte("\n"), -1)(gocritic)cobrarepocobrarepo).actions/checkout,actions/setup-go@v5andgolangci/golangci-lint-actionversions