Skip to content

feat(ToStringMapStringE): Add support for non string JOSN value #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
icbd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(ToStringMapStringE): Add support for non string JOSN value #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cast_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,6 +907,8 @@ func TestToStringMapStringE(t *testing.T) {
var jsonString = `{"key 1": "value 1", "key 2": "value 2", "key 3": "value 3"}`
var invalidJsonString = `{"key 1": "value 1", "key 2": "value 2", "key 3": "value 3"`
var emptyString = ""
var jsonStringWithNonString = `{"key 1": "100", "key 2": -200, "key 3": 3.1415926}`
var mapStringWithNonString = map[string]string{"key 1": "100", "key 2": "-200", "key 3": "3.1415926"}

tests := []struct {
input interface{}
Expand All @@ -918,6 +920,7 @@ func TestToStringMapStringE(t *testing.T) {
{interfaceMapString, stringMapString, false},
{interfaceMapInterface, stringMapString, false},
{jsonString, stringMapString, false},
{jsonStringWithNonString, mapStringWithNonString, false},

// errors
{nil, nil, true},
Expand Down
7 changes: 5 additions & 2 deletions caste.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,8 +874,11 @@ func ToStringMapStringE(i interface{}) (map[string]string, error) {
}
return m, nil
case string:
err := jsonStringToObject(v, &m)
return m, err
var temp = map[string]interface{}{}
if err := jsonStringToObject(v, &temp); err != nil {
return nil, err
}
return ToStringMapStringE(temp)
default:
return m, fmt.Errorf("unable to cast %#v of type %T to map[string]string", i, i)
}
Expand Down
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
module github.com/spf13/cast

go 1.15

require (
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
Expand Down