fix: Ensure model selection checkmark persists across navigation#35
Open
spenceriam wants to merge 1 commit intomainfrom
Open
fix: Ensure model selection checkmark persists across navigation#35spenceriam wants to merge 1 commit intomainfrom
spenceriam wants to merge 1 commit intomainfrom
Conversation
- Add useEffect to set modelLoadStatus to 'success' when hasModel is true - This ensures the green checkmark persists when navigating back to model selection - Fixes issue where selected model didn't show checkmark after returning to model screen Fixes #26
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| if (hasModel && modelLoadStatus !== 'success') { | ||
| setModelLoadStatus('success') | ||
| } | ||
| }, [hasModel, modelLoadStatus]) |
There was a problem hiding this comment.
Bug: Effect Hook Forcing False Positives on Loading Status
The new useEffect unconditionally sets modelLoadStatus to 'success' whenever hasModel is true, which overrides 'loading' and 'error' states emitted by ModelSelector (via onLoadingChange and onError). This can mask failures and prematurely clear loading indicators, showing a green checkmark even when model loading fails or is in progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where the green checkmark for AI model selection would disappear when navigating back to the model selection screen.
Changes Made
Testing
Fixes #26
Note
Set
modelLoadStatustosuccessvia a new effect whenhasModelis true, keeping the model selection checkmark persistent.Written by Cursor Bugbot for commit 18af2bc. This will update automatically on new commits. Configure here.