Conversation
|
Welcome @imdevin567! It looks like this is your first PR to spectrocloud/cluster-api-provider-maas 🎉 |
|
Hi @imdevin567. Thanks for your PR. I'm waiting for a spectrocloud member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@imdevin567 could you please help rebase the branch against main |
|
@sadysnaat the feature branch is up to date with main, is there anything else this is waiting on? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: imdevin567, sadysnaat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@AmitSahastra let's verify cluster creation end to end with these changes |
|
@imdevin567 Cloud you please squash commit or create a new pr with changes so we don't have old commits showing up here. |
AmitSahastra
left a comment
There was a problem hiding this comment.
squash commits or create new pr.
b6b4fd1 to
2b955e8
Compare
|
Hey @AmitSahastra , sorry for the delay. I've resolved the branching/commit issue. |
clusterctlcan't create the cert via cert-manager because the API version is wrong.