Skip to content

chore: Make workers replicas configurable#121

Open
imusmanmalik wants to merge 2 commits intospectrocloud:mainfrom
imusmanmalik:main
Open

chore: Make workers replicas configurable#121
imusmanmalik wants to merge 2 commits intospectrocloud:mainfrom
imusmanmalik:main

Conversation

@imusmanmalik
Copy link
Copy Markdown

@imusmanmalik imusmanmalik commented Dec 19, 2023

Replicas for worker machines are not configurable, hence when generating using:

clusterctl generate cluster t-cluster --infrastructure=maas:v0.5.0 --kubernetes-version v1.26.4 --control-plane-machine-count=1 --worker-machine-count=2  > maas-cluster-api.yaml

--worker-machine-count=2 is not reflected in the generated MachineDeployment spec.replicas as its hardcoded and not templated.

Tested by providing overrides:

├── overrides
│   └── infrastructure-maas
│       └── v0.5.0
│           └── cluster-template.yaml

Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
@sadysnaat sadysnaat self-requested a review July 3, 2024 09:57
@imusmanmalik
Copy link
Copy Markdown
Author

@sadysnaat is there anything else that is blocking to merge this in ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants