chore: Make workers replicas configurable#121
Open
imusmanmalik wants to merge 2 commits intospectrocloud:mainfrom
Open
chore: Make workers replicas configurable#121imusmanmalik wants to merge 2 commits intospectrocloud:mainfrom
imusmanmalik wants to merge 2 commits intospectrocloud:mainfrom
Conversation
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
sadysnaat
approved these changes
Jul 3, 2024
Author
|
@sadysnaat is there anything else that is blocking to merge this in ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicas for worker machines are not configurable, hence when generating using:
clusterctl generate cluster t-cluster --infrastructure=maas:v0.5.0 --kubernetes-version v1.26.4 --control-plane-machine-count=1 --worker-machine-count=2 > maas-cluster-api.yaml--worker-machine-count=2is not reflected in the generatedMachineDeploymentspec.replicasas its hardcoded and not templated.Tested by providing overrides: