update go and improve node state checks#1
Open
x100111010 wants to merge 21 commits intospectre-project:mainfrom
Open
update go and improve node state checks#1x100111010 wants to merge 21 commits intospectre-project:mainfrom
x100111010 wants to merge 21 commits intospectre-project:mainfrom
Conversation
…es on unstandard ports
- tn10 (18211) is already defined in spectred so it doesn't need explicit handling, it only makes sense for tn11
- ignore addresses with port = 0 - log address for invalid name
- V5 is being used in go-spectred - V6 and above is rusty-spectre and it will be V7 post sigma, so this is easier compared to checking the node version (using regex) from the user agent
because go-spectred testnet uses suffix 1
…in p2p version - support for MinProtoVer: minprotocolversion - support for MinUaVer: min node version - avoid collecting peers for nodes below minimum protocol version - properly identify dns seeder with name and version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addressmanager.IsRoutableAddAddressesdefaultStaleGoodTimeoutdefaultStaleGoodTimeoutago or more thandefaultStaleBadTimeoutpruneExpireTimeout^Credits: @supertypo
really nice changes!
ignore addresses with port = 0
log address for invalid name
log the user agent and p2p version
only accept peers as good if protocol version >= 6so this is easier compared to checking the node version (using regex) from the user agentsupport for
MinProtoVer: minprotocolversionsupport for
MinUaVer: min node versionavoid collecting peers for nodes below minimum protocol version
properly identify dns seeder with name and version
update dep and tidy