add convertTheory for CommonLogic #2128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcodescu
reviewed
Dec 15, 2022
Collaborator
mcodescu
left a comment
mcodescu
left a comment
There was a problem hiding this comment.
The code looks good but when I try out the example from the issue, I get
logic CommonLogic.FirstOrder
(cl-comment "name-a" (P a)) (cl-comment "name-b" (P b)) (P c)
Is this still one sentence or is this a problem with the printing?
Contributor
|
I need to discuss #2133 with @fabianneuhaus first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #2110