Skip to content

Conversation

@chrille0313
Copy link
Contributor

Fixes #96

@chrille0313
Copy link
Contributor Author

We could potentially consider labeling projects with react-router-dom@<7 as the old react-router-dom library and versions >= 7 as react-router, but the current rule system doesn't allow (as far as I know) to distinguishing between specific library versions

Copy link
Collaborator

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think I just messed up the names here; I should not have gone with reactrouterdom.

We can't change the ID of tech, or it will break a lot of things, so it has to stay reactrouterdom but we can change the name for sure.

Is it a problem for you? I can think of a better solution otherwise (I have none rn ahah)

@chrille0313
Copy link
Contributor Author

chrille0313 commented Nov 26, 2025

We can't change the ID of tech, or it will break a lot of things, so it has to stay reactrouterdom but we can change the name for sure.

Is it a problem for you? I can think of a better solution otherwise (I have none rn ahah)

My issues are resolved as long as we can detect the npm dependency "react-router" as "React Router" and not "React Router Dom". Would this be the case if we only change the name?

@bodinsamuel
Copy link
Collaborator

My issues are resolved as long as we can detect the npm dependency "react-router" as "React Router" and not "React Router Dom". Would this be the case if we only change the name?

Yes should be.
I'll let you update the PR and I'll merge ☺️

@chrille0313
Copy link
Contributor Author

chrille0313 commented Nov 26, 2025

Kept only the name change like requested.

@bodinsamuel bodinsamuel merged commit e393ff7 into specfy:main Nov 27, 2025
2 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 27, 2025
## [1.27.4](v1.27.3...v1.27.4) (2025-11-27)

### Bug Fixes

* focus .rs on rust ([ce96034](ce96034))
* **rules:** consolidate react router ([#97](#97)) ([e393ff7](e393ff7)), closes [#96](#96)
@bodinsamuel
Copy link
Collaborator

Released under 1.27.4
Please let me know if that works for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] react-router gets incorrectly recognized as react-router-dom

2 participants