-
-
Notifications
You must be signed in to change notification settings - Fork 26
fix(rules): consolidate react router #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We could potentially consider labeling projects with react-router-dom@<7 as the old react-router-dom library and versions >= 7 as react-router, but the current rule system doesn't allow (as far as I know) to distinguishing between specific library versions |
bodinsamuel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I think I just messed up the names here; I should not have gone with reactrouterdom.
We can't change the ID of tech, or it will break a lot of things, so it has to stay reactrouterdom but we can change the name for sure.
Is it a problem for you? I can think of a better solution otherwise (I have none rn ahah)
My issues are resolved as long as we can detect the npm dependency "react-router" as "React Router" and not "React Router Dom". Would this be the case if we only change the name? |
Yes should be. |
a0ee904 to
8fa7d30
Compare
|
Kept only the name change like requested. |
|
Released under 1.27.4 |
Fixes #96