Conversation
…x#195) Signed-off-by: Dominik Schmidt <dev@dominik-schmidt.de>
dschmidt
force-pushed
the
fix/external-document-ref-in-creation-info
branch
from
a59e85e to
756325d
Compare
Contributor
Author
|
you're welcome, thanks for reacting so quickly :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195
The tag-value parser rejected valid SPDX documents where
ExternalDocumentRefappeared afterCreator/Createdtags. The spec doesn't mandate field ordering, so the parser was too strict.Adds
ExternalDocumentRefas a recognized tag inparsePairFromCreationInfofor v2_1, v2_2, and v2_3 — using the same delegation pattern already used forDocumentComment.