Adding support for Llama 3.1 and Llama 3.2 models#59
Open
Adding support for Llama 3.1 and Llama 3.2 models#59
Conversation
fixing token_wise rotation size when different from value size
Fixing rotation issue due to tie_weight
Llama3.2 and Llama3
support for llama 3.1
|
This is very helpful for my current work comparing QuaRot on Llama-3.2. Thank you very much! Would appreciate if the author can review and merge if applicable. @sashkboos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main modifications to support Llama 3.1 and 3.2:
tie_word_embedding=Trueso we need to do only one the rotation on input embedding as they are the same data has the output ones.config.num_key_value_headsis different fromconfig.num_attention_heads, we need to give the full formula :config.hidden_size * config.num_key_value_heads / config.num_attention_headsto get the right dimension.