Skip to content
This repository was archived by the owner on Oct 19, 2020. It is now read-only.

Partially fix overlapping dependencies#14

Open
spautz wants to merge 8 commits intomasterfrom
fix-overlapping-dependencies
Open

Partially fix overlapping dependencies#14
spautz wants to merge 8 commits intomasterfrom
fix-overlapping-dependencies

Conversation

@spautz
Copy link
Copy Markdown
Owner

@spautz spautz commented Dec 11, 2018

This changeset goes pretty far towards fixing issue #13 , but there's still something outstanding that I haven't nailed down yet.

Pushing this PR now because (1) the changset includes several immediate fixes, and (2) test coverage is expanded to include the known reasons behind #13, even though there seem to still be some unknown-and-unaddressed issues behind it.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 20

  • 179 of 238 (75.21%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 75.267%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/util/assertCountsForParams.js 7 8 87.5%
tests/premade-selectors/appointmentSelectors.js 25 35 71.43%
src/parameterizedSelectorFactory.js 75 123 60.98%
Totals Coverage Status
Change from base Build 17: -0.2%
Covered Lines: 335
Relevant Lines: 422

💛 - Coveralls

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 20

  • 179 of 238 (75.21%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 75.267%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/util/assertCountsForParams.js 7 8 87.5%
tests/premade-selectors/appointmentSelectors.js 25 35 71.43%
src/parameterizedSelectorFactory.js 75 123 60.98%
Totals Coverage Status
Change from base Build 17: -0.2%
Covered Lines: 335
Relevant Lines: 422

💛 - Coveralls

1 similar comment
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 20

  • 179 of 238 (75.21%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 75.267%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/util/assertCountsForParams.js 7 8 87.5%
tests/premade-selectors/appointmentSelectors.js 25 35 71.43%
src/parameterizedSelectorFactory.js 75 123 60.98%
Totals Coverage Status
Change from base Build 17: -0.2%
Covered Lines: 335
Relevant Lines: 422

💛 - Coveralls

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 20

  • 179 of 238 (75.21%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 75.267%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/util/assertCountsForParams.js 7 8 87.5%
tests/premade-selectors/appointmentSelectors.js 25 35 71.43%
src/parameterizedSelectorFactory.js 75 123 60.98%
Totals Coverage Status
Change from base Build 17: -0.2%
Covered Lines: 335
Relevant Lines: 422

💛 - Coveralls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants