Stop insertRequire being passed to rjs if false#7
Open
dfrencham wants to merge 1 commit intospatools:masterfrom
Open
Stop insertRequire being passed to rjs if false#7dfrencham wants to merge 1 commit intospatools:masterfrom
dfrencham wants to merge 1 commit intospatools:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If insertRequire is set to false/null/undefined or has no value set, it appends the following to the built file:
This is due to the
_.uniq(params.insertRequire)returning an empty array if passed any value that is not an array. This results in an empty array being passed to rjs which appends a require call to the built file if any array is passed in viainsertRequire.My change allows insertRequire to be explicitly set to false. This stops the array assignment, and prevents the empty require call from being added.