Draft
Conversation
|
Hi @heidkaemper, thank you for your work! Have u any news about the PR status? |
Contributor
Author
|
@eliavnn Most of the necessary work is probably already done. However, I would like to get some feedback from Spatie about the future of this package before starting the work on final touches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks!
We'd love to use the Responsive Images Addon in Statamic v6 projects. And I went ahead and prepared this PR for v6 support. Above all, to check how many changes are likely to be necessary.
The most important changes so far:
After these changes, the addon now works with Statamic v6. However, it is not yet finished. The UX could be improved. And the tests could certainly be tidied up even further.
Now I would like to get some feedback. Is it alright that I started with v6 support? Or would you prefer to make the adjustments yourself? And is further support for the package still on your agenda?