Fix incorrect dimensions when switching aspect ratios#265
Open
ranjith67 wants to merge 1 commit intospatie:mainfrom
Open
Fix incorrect dimensions when switching aspect ratios#265ranjith67 wants to merge 1 commit intospatie:mainfrom
ranjith67 wants to merge 1 commit intospatie:mainfrom
Conversation
- Constrain calculated dimensions to original image bounds - Ensure width and height never exceed source image size - Handle both landscape->portrait and portrait->landscape switches - Add test cases to verify dimensions stay within original bounds Fixes spatie#257
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #257 - Incorrect width/height when switching aspect ratios
Problem
When switching aspect ratios (e.g., from 16:9 to 9:16), the calculated dimensions could exceed the original image size, resulting in invalid image requests.
Solution
calculateForImgTag()andcalculateDimensions()methodsChanges
src/ResponsiveDimensionCalculator.phptests/Feature/DimensionCalculatorTest.phpTesting
Added unit tests to verify: