Fix: Add Carnival Tuesday as public holiday for Venezuela#313
Fix: Add Carnival Tuesday as public holiday for Venezuela#313MathewsJose wants to merge 1 commit intospatie:mainfrom
Conversation
|
Can you take care of the failing tests and phpstan? |
|
I’ve been looking into the failing PHPStan and test jobs, and it seems the issue is related to a Composer dependency conflict with pestphp/pest. At the moment, composer.json allows: "pestphp/pest": "^2.31|^3.0|^4.0" However, Composer is struggling to resolve this range in CI because some of the 2.x releases (notably 2.34.9–2.36.0) have unmet transitive dependencies. As a result, composer install fails and the workflow stops early. Possible approaches I see a few ways we could address this: Option 1 (my suggestion): Adjust the Pest version constraint "pestphp/pest": "^2.31 <2.34.9 || ^2.36.1 || ^3.0 || ^4.0" Or simplify to: "pestphp/pest": "^2.31 || ^3.0 || ^4.0" and let Composer resolve a compatible version cleanly. Option 2: Update the CI workflow Option 3: Temporarily pin Pest to a known working 2.x version Would you be okay with me proceeding with Option 1, or would you prefer a different approach? Happy to follow your preferred direction 🙂 |
Fix: Missing Carnival Tuesday Holiday for Venezuela
February 17th, 2026 corresponds to Carnival Tuesday (Martes de Carnaval), which is a national public holiday in Venezuela.
What was changed?
Added Carnival Tuesday as a public holiday for Venezuela.
Implemented it dynamically relative to Easter (47 days before Easter Sunday).
Added test coverage for 2026.