Open
Conversation
…d Deepavali with lookup tables
Fix existing country holiday bugs
V2: Introduce Holiday value object and HolidayType enum
V2: Replace glob-based country discovery with static CountryRegistry
V2: Remove country/year override parameters from Holidays API
…arsing from Country::get()
V2: Require CarbonImmutable
V2: Standardize regional holidays with HasRegions interface
V2: Add support for regional, observed, banked and religious holidays
V2: Improve Islamic calendar contracts
V2: Extend API functionalities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major version rewrite focused on type safety, performance, and a cleaner architecture. Breaking changes are documented in UPGRADING.md.
For users
get()andgetInRange()now returnHoliday[]value objects instead of plain arraysHolidays::for()accepts aregionparameter directlyFor contributors
CarbonImmutablethroughout — no more implicit string parsingCountrybase classHasRegionsinterface standardizes regional holidaysHasObservedHolidaystrait replacesObservablewith clearer method signaturesResolvesCalendarDatestrait deduplicates calendar logicCountryRegistryreplaces filesystem scanningPerformance
glob()Links