stacks: rework e4s to enforce a single AMD architecture#3571
Open
alalazo wants to merge 4 commits intospack:developfrom
Open
stacks: rework e4s to enforce a single AMD architecture#3571alalazo wants to merge 4 commits intospack:developfrom
alalazo wants to merge 4 commits intospack:developfrom
Conversation
Signed-off-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
This one introduces environment groups, which are necessary for the changes in the stack. Signed-off-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
This should enforce a single AMD architecture across the entire stack. Signed-off-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
alalazo
requested review from
a team,
alecbcs,
becker33,
eugeneswalker,
tgamblin and
tldahlgren
as code owners
alalazo
added
don't-merge-yet
pipelines:urgent
eugeneswalker
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #3561
Currently, the AMD software built in the
e4spipelines is causing a lot of latency for other pipelines to run. One possible cause is the fact that some nodes in the DAG getamdgpu_target:=autoand thus build for a huge number of targets (thanks @haampie for noticing that).See for instance:
that gets to 99% completion in ~4hrs then fails. These build failures are retried 3 times, amounting to ~12hrs waiting time for the PRs that are gated on
developpipelines to finish.In this PR we try to pin the entire
e4sstack to build a single AMD target, and see it that helps with the build times and failure rates.