-
Notifications
You must be signed in to change notification settings - Fork 27
add pytest_crds as an entrypoint
#211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
543f59b to
11fbb09
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 95.22% 95.08% -0.15%
==========================================
Files 37 38 +1
Lines 3165 3172 +7
==========================================
+ Hits 3014 3016 +2
- Misses 151 156 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
As this package is used by romancal (and we've heard about uses for other projects) I think jwst (or another package) is the right home for this plugin (if the plugin is still useful). EDIT: after discussion about potential usefulness for roman my vote is to update this PR to be compatible with both packages and for uses where crds might not be used. |
|
Why not just always enable the reporting? Not like romancal can run without CRDS. I don't think you need a whole plugin to just control a test header. |
| if config.getoption("report_crds_context"): | ||
| from stpipe.crds_client import get_context_used | ||
|
|
||
| return f"crds_context: {get_context_used('jwst')}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be "jwst" anymore here if you decide to keep it?
moves
pytest_crdsplugin fromjwstto here.pytest_crdsis a PyTest plugin that reports the CRDS context in thepytestoutput if you add the--report-crds-contextflagcorresponding PR in
jwst:pytest_crdsplugin jwst#9001Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)"git+https://github.com/<fork>/stpipe@<branch>")jwstregression testromancalregression testnews fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change