Allows input from external DMX sources.#36
Open
Breina wants to merge 3 commits intospacemanspiff2007:masterfrom
Open
Allows input from external DMX sources.#36Breina wants to merge 3 commits intospacemanspiff2007:masterfrom
Breina wants to merge 3 commits intospacemanspiff2007:masterfrom
Conversation
* Provide a way to update a universe's data (partially). * Reverse output correct the DMX data, so that the same uncorrected input values reflect in the same corrected outputs. * Add a callback for channels that changed, containing the new values.
Author
|
Your GitHub integration is pretty rad btw! |
Co-authored-by: spacemanspiff2007 <a.b@c>
Open
…ess to its values. In practice, ArtNetController needs these values in order to send them itself.
Owner
I'm unsure about that. I think we should just accept the raw data as raw dmx input and not reverse correct it. |
Author
|
Alrighty take your time! Better to do it properly than to rush. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to make the output correction a class, so that I could give it 2 functions for applying corrections in two ways. Not sure if that's the pythonic way.
This is just a suggestion, let me know if you envision another approach.
Fixes #31