Skip to content

Can pbuf bug #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johandc merged 3 commits into from
Mar 10, 2026
Merged

Can pbuf bug #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca83b4d
pbuf: fix use after free possibility and fast return
edvardxyz Mar 9, 2026
c71cc45
pbufs: eth & can remove use after free possiblity
edvardxyz Mar 9, 2026
43d44e1
pbuf: pbuf free just use packet->next
edvardxyz Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/interfaces/csp_if_can_pbuf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ void csp_can_pbuf_free(csp_can_interface_data_t * ifdata, csp_packet_t * buffer,
csp_buffer_free_isr(packet);
}
}

return;
}

prev = packet;
Expand Down Expand Up @@ -73,14 +73,16 @@ void csp_can_pbuf_cleanup(csp_can_interface_data_t * ifdata, int * task_woken) {

while (packet) {

csp_packet_t * next = packet->next;

/* Perform cleanup in used pbufs */
if (now - packet->last_used > PBUF_TIMEOUT_MS) {

/* Erase from list prev->next = next */
if (prev) {
prev->next = packet->next;
prev->next = next;
} else {
ifdata->pbufs = packet->next;
ifdata->pbufs = next;
}

if (task_woken == NULL) {
Expand All @@ -89,10 +91,13 @@ void csp_can_pbuf_cleanup(csp_can_interface_data_t * ifdata, int * task_woken) {
csp_buffer_free_isr(packet);
}

packet = next;
continue;

}

prev = packet;
packet = packet->next;
packet = next;
}

}
Expand Down
12 changes: 9 additions & 3 deletions src/interfaces/csp_if_eth_pbuf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ void csp_eth_pbuf_free(csp_eth_interface_data_t * ifdata, csp_packet_t * buffer,
csp_buffer_free_isr(packet);
}
}
return;
}

prev = packet;
Expand Down Expand Up @@ -68,14 +69,16 @@ void csp_eth_pbuf_cleanup(csp_eth_interface_data_t * ifdata, uint32_t now, int *

while (packet) {

csp_packet_t * next = packet->next;

/* Perform cleanup in used pbufs */
if ((now - packet->last_used) > PBUF_TIMEOUT_MS) {

/* Erase from list prev->next = next */
if (prev) {
prev->next = packet->next;
prev->next = next;
} else {
ifdata->pbufs = packet->next;
ifdata->pbufs = next;
}

if (task_woken == NULL) {
Expand All @@ -84,10 +87,13 @@ void csp_eth_pbuf_cleanup(csp_eth_interface_data_t * ifdata, uint32_t now, int *
csp_buffer_free_isr(packet);
}

packet = next;
continue;

}

prev = packet;
packet = packet->next;
packet = next;
}

}
Expand Down