Nix: Fix file selection in the client under NixOS#276
Closed
marius851000 wants to merge 1 commit intospace-wizards:masterfrom
Closed
Nix: Fix file selection in the client under NixOS#276marius851000 wants to merge 1 commit intospace-wizards:masterfrom
marius851000 wants to merge 1 commit intospace-wizards:masterfrom
Conversation
Contributor
|
So I messed around with this a bit more (I knew it was a issue but didn't know why) and found it was from a missing dependency in sdl for dbus, should be more ideal to fix it that way then this way around. |
Contributor
|
Fixed with dbus in #277 |
Author
|
Cool. I'll go test your PR as soon as I'm able to.
|
Author
|
Closing in favor of #277 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, the portal method does not work for me, to pick MIDI file to play. I hence opted to make use of zenity, which just mean that I needed to provide the good program in PATH, that SDL support.
I don’t really know why XDG portal does not work, thought. But this work just as good.
(ps: file picker in the launcher itself (for replay) already worked and still work)
I don’t know if this Nix file work on MacOS. But I have no MacOS machine to test it, so I made sure to only enable it on Linux.