Add Fluidsynth-backed MIDI controls#6469
Open
QTNeen wants to merge 5 commits intospace-wizards:masterfrom
Open
Add Fluidsynth-backed MIDI controls#6469QTNeen wants to merge 5 commits intospace-wizards:masterfrom
QTNeen wants to merge 5 commits intospace-wizards:masterfrom
Conversation
Author
|
If there's any testing you'd like me to run that'd make it easier for you to review just let me know |
Add method to set reverb for a specific MIDI channel.
Removed unnecessary blank lines and adjusted formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends IMidiRenderer/MidiRenderer with channel filter cut off, tempo and pitch shift and reverb.
This backend allows additional control to midi channels for future additions to instruments.
First PR for the engine, so I'm not sure what information is required, but this change would allow changes to be made to the midi stream via a channel mixer
