Fix ApplyLinearImpulse treating the impulse as being both in world and local space#6444
Open
SlamBamActionman wants to merge 1 commit intospace-wizards:masterfrom
Open
Conversation
…ed in local coordinates
Member
|
Here a PR that showed the bug in action (see Ed's video below) and can be used for testing. |
Tayrtahn
added
T: Bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short and simple fix for a function used in literally one place (soon two) in Content.
In short,
SetLinearVelocityuses impulse as it's in world space, whileSetAngularVelocitytreats it as if it is in local space. Cue incorrect angular velocity being applied. This PR changes the local positions into being in world space.