Refactor ComponentRegistry to encourage correct usage.#6442
Open
moonheart08 wants to merge 24 commits intospace-wizards:masterfrom
Open
Refactor ComponentRegistry to encourage correct usage.#6442moonheart08 wants to merge 24 commits intospace-wizards:masterfrom
moonheart08 wants to merge 24 commits intospace-wizards:masterfrom
Conversation
2 tasks
moonheart08
force-pushed
the
09-03-2026-component-registry-refactor
branch
from
8e80522 to
93e4cbf
Compare
This was referenced Mar 10, 2026
Member
|
Blessed PR. |
Robust.Shared.IntegrationTests/GameObjects/EntityManagerFilterTests.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Remark: ComponentFilterQuery should just be rewritten to use DynamicEntityQuery from my other PR, but I don't want to merge these two for review reasons atm. When someone judges these ready for merge, let me know and I'll just merge the two PRs into one so I can do that rewrite. |
Tayrtahn
added
T: Refactor
…thNewComponents and FillMissesFromRegistry.
This reverts commit 8e6a885.
moonheart08
force-pushed
the
09-03-2026-component-registry-refactor
branch
from
8aad3dd to
3fa6786
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all of the API surface that exposed ComponentRegistry as a dictionary, leaving the remaining necessary surface [Obsolete].
This also simplifies certain common usecases for ComponentRegistry, and pushes the user toward not using it as a filter list.
This also adds
ComponentFilter, a (much more ergonomic) replacement for the ComponentRegistry-as-filters misuse.Resolves #6440 as much as possible while requiring minimal content PRs. Further content PRs are part 2.