Fix VRAM leak in MapChunk edge rendering#6441
Open
B-Kirill wants to merge 3 commits intospace-wizards:masterfrom
Open
Fix VRAM leak in MapChunk edge rendering#6441B-Kirill wants to merge 3 commits intospace-wizards:masterfrom
B-Kirill wants to merge 3 commits intospace-wizards:masterfrom
Conversation
moonheart08
suggested changes
Mar 9, 2026
Contributor
moonheart08
left a comment
moonheart08
left a comment
There was a problem hiding this comment.
Keep the GL error checks, so we actually know which operation errored out.
Contributor
Author
Oh, I didn't think about it in that context. Then yes, it should stay. |
…ion methods" This reverts commit a48ffd7.
Tayrtahn
added
T: Bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting a map chunk, the
DeleteChunkmethod inClyde.GridRendering.csfrees the mainVAO/VBO/EBObut does not freeEdgeVAO/EdgeVBO/EdgeEBOwhich leads to a VRAM leak.Just added the deletion of these objects.