Allow static abstract through the sandbox + INumber#6432
Open
moonheart08 wants to merge 5 commits intospace-wizards:masterfrom
Open
Allow static abstract through the sandbox + INumber#6432moonheart08 wants to merge 5 commits intospace-wizards:masterfrom
static abstract through the sandbox + INumber#6432moonheart08 wants to merge 5 commits intospace-wizards:masterfrom
Conversation
moonheart08
changed the title
static abstract through the sandboxstatic abstract through the sandbox + INumber
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows call of static abstract methods, and the usage of
.constrainedon such methods, as the C# compiler does.An example of an interface you previously could not use in content due to this is
INumber<T>, from .NET 7.This, thusly, also whitelists INumber & co.
This additionally whitelists the IParsable and IFormattable families of interfaces, also from .NET 7.
Remarks
This is not a perfect fix, but the invalid constructs it allows (namely, incorrect constrained usage, and calling abstract methods that are truly abstract) result in the CLR throwing an exception, not unexpected CLR behavior.
A perfect fix would require us to fork ILVerify, as upstream (the .NET runtime) no longer maintains it in significant capacity.
Such a fork would also potentially enable other constructs, like
Span<T> foo = stackalloc T[n]and[InlineArray], to be valid in client side code.