Skip to content

Fix OnClientRequestFull throwing an error when trying to log data about a deleted entity #6420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DrSmugleaf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix OnClientRequestFull throwing an error when trying to log data about a deleted entity #6420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Robust.Server/GameStates/PvsSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,10 +241,9 @@ private void OnClientRequestFull(ICommonSession session, GameTick tick, NetEntit
var sb = new StringBuilder();
sb.Append($"Client {session} requested full state on tick {tick}. Last Acked: {lastAcked}. Curtick: {_gameTiming.CurTick}.");

if (missingEntity != null)
if (missingEntity != null && TryGetEntityData(missingEntity.Value, out var uid, out _))
Copy link
Contributor

@moonheart08 moonheart08 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not still log and just remark the entity doesn't exist? It likely existed previously.

{
var (entity, meta) = GetEntityData(missingEntity.Value);
sb.Append($" Apparently they received an entity without metadata: {ToPrettyString(entity)}.");
sb.Append($" Apparently they received an entity without metadata: {ToPrettyString(uid)}.");
//sb.Append($" Entity last seen: {meta.PvsData[sessionData.Index].EntityLastAcked}");
}

Expand Down
Loading