Skip to content

Conversation

@ns-vasilev
Copy link
Member

No description provided.

@ns-vasilev ns-vasilev self-assigned this Dec 10, 2025
@ns-vasilev ns-vasilev requested a review from a team as a code owner December 10, 2025 05:21
@spacecode-github-bot
Copy link

1 Warning
⚠️ Public API changed but no documentation updates found

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 85.24590% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.72%. Comparing base (b4b31c1) to head (73818df).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ses/AppKit/Extensions/NSTextField+Validation.swift 57.14% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   93.91%   93.72%   -0.19%     
==========================================
  Files          54       56       +2     
  Lines        2695     2756      +61     
==========================================
+ Hits         2531     2583      +52     
- Misses        164      173       +9     
Files with missing lines Coverage Δ
...torUITests/UnitTests/AppKit/NSTextFieldTests.swift 100.00% <100.00%> (ø)
...atorUITests/UnitTests/UIKit/UITextFieldTests.swift 100.00% <ø> (ø)
...datorUITests/UnitTests/UIKit/UITextViewTests.swift 100.00% <ø> (ø)
...ses/AppKit/Extensions/NSTextField+Validation.swift 57.14% <57.14%> (ø)

@ns-vasilev ns-vasilev marked this pull request as draft December 10, 2025 06:31
@ns-vasilev ns-vasilev force-pushed the feature/ns-text-field branch 2 times, most recently from 3901a2f to 523170a Compare December 19, 2025 19:01
@ns-vasilev ns-vasilev marked this pull request as ready for review December 19, 2025 19:01
@ns-vasilev ns-vasilev force-pushed the feature/ns-text-field branch 2 times, most recently from 8ce4ff6 to 083ac70 Compare December 19, 2025 19:39
@ns-vasilev ns-vasilev force-pushed the feature/ns-text-field branch from 083ac70 to 73818df Compare December 20, 2025 07:02
@ns-vasilev ns-vasilev merged commit a19d2da into main Dec 20, 2025
30 checks passed
@ns-vasilev ns-vasilev deleted the feature/ns-text-field branch December 20, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants