This repository was archived by the owner on Mar 24, 2020. It is now read-only.
Completed MapReduce Functionality for Average Scores by Domain #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
There was a problem hiding this comment.
I don't think reduce would be called if there were zero values, but divide-by-zero is a nasty condition, so I check for it anyway.
Author
There was a problem hiding this comment.
I didn't use guava, so no need to explicitly include it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I've implemented what was requested here. There was no guideline as to how to handle invalid data in the input file, so I assumed that it should be ignored pending a requirement. I tried to keep everything simple and straightforward.
Ready for review.