Remove redundant Homebrew placeholder and fix dry-run hang#36
Remove redundant Homebrew placeholder and fix dry-run hang#36southpawriter02 wants to merge 1 commit intomainfrom
Conversation
…y-run The `install/install-homebrew-packages.sh` script was a placeholder and its functionality is fully covered by `install/03-homebrew-installation.sh`. This change removes the redundant file. Additionally, `install/03-homebrew-installation.sh` has been updated to conditionally skip the progress bar simulation in dry-run mode when running non-interactively. This prevents tests from hanging due to excessive output or blocking behavior in CI environments. Co-authored-by: southpawriter02 <207498890+southpawriter02@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Removed
install/install-homebrew-packages.shas it was an unused placeholder.Updated
install/03-homebrew-installation.shto prevent dry-run simulation loop from running in non-interactive mode, which caused tests to hang.PR created automatically by Jules for task 2076563008380597880 started by @southpawriter02