Open
Conversation
- Add LIMITATIONS.md documenting platform support and constraints - Move test cookbook to test/cookbooks/test/, remove old fixtures - Replace ServerSpec with InSpec profiles for default/standalone suites - Remove 4 stale templates (confluence.init, crowd.properties, response.varfile, web_app.conf) - Add :delete action to confluence_service and confluence_config resources - Extend :remove action on confluence_install to also delete home_path - Add frozen_string_literal: true to all Ruby files - Fix kitchen.yml: chef_infra provisioner, updated run_list refs, InSpec verifier paths - Remove EOL platforms from kitchen.global.yml (debian-11, ubuntu-20.04, opensuse-leap-15) - Add oraclelinux-8/9 to CI matrix to match kitchen.dokken.yml - Update documentation for new :delete/:remove actions - 64 ChefSpec examples, 0 failures
Slowest examplesTop 10 slowest examples (0.5 seconds, 31.83% of total time)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the
chef-custom-resourcesworkflow across all six phases.Changes
Phase 1: Research
LIMITATIONS.mddocumenting platform support, architecture, Java requirements, and known incompatibilitiesPhase 2: Structure
test/fixtures/cookbooks/confluence_test/→test/cookbooks/test/Berksfileto reference new test cookbook pathkitchen.yml: provisionerchef_zero→chef_infra, run_list refsconfluence_test::*→test::*, add InSpec verifier pathskitchen.global.yml(debian-11, ubuntu-20.04, opensuse-leap-15)oraclelinux-8andoraclelinux-9to CI matrix in.github/workflows/ci.ymlPhase 3: Resources
# frozen_string_literal: trueto all Ruby files:deleteaction toconfluence_service— stops, disables, and deletes the systemd unit:deleteaction toconfluence_config— removes all 3 managed config files:removeaction onconfluence_installto also removehome_pathPhase 4: ChefSpec (TDD)
:delete/:removeactions (written before implementation)frozen_string_literaland documentation formatter tospec_helper.rbPhase 5: Integration Tests
defaultandstandalonesuitesinspec.yml+controls/with named controls per conventionPhase 6: Documentation
:deleteaction toconfluence_service.mdandconfluence_config.md:removedescription inconfluence_install.mdto reflect home_path removal