fix(shared): improve config validation error message for local git connections#1047
Conversation
…nnections When a file:// URL is detected in a failing connection, append a hint to the error message explaining that the repository must be mounted into the Docker container and the URL must reflect the container-internal path, not the host machine path. Fixes sourcebot-dev#1044
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe change enhances error handling in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This is logging a hint when we're validating the schema of the config and not when we actually try to pull the local github repo. |
When a user configures a local git connection with a file:// URL but forgets to mount the repo into the Docker container, the error thrown is raw AJV output which is hard to understand.
This PR appends a plain-English hint to the error when a file:// URL is detected, telling the user to mount the repo and use the container-internal path.
Fixes #1044
Summary by CodeRabbit