Skip to content

process reserved subtrees (case when exists etc) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobbysmith007 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

process reserved subtrees (case when exists etc) #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73c7ab8
process reserved subtrees (case when exists etc)
bobbysmith007 Mar 30, 2015
fc4b9b8
Adding some processFunction, processColRef that allow creation of a
bobbysmith007 Apr 21, 2015
a03e3ce
Fixing CAST statement generation (was putting a comma after the column
Apr 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/PHPSQL/Creator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,8 +413,8 @@ protected function processFunction($parsed) {
if ($len == strlen($sql)) {
throw new \PHPSQL\Exception\UnableToCreateSQL('function subtree', $k, $v, 'expr_type');
}

$sql .= ($this->isReserved($v) ? " " : ",");
$sql .= ($this->isReserved($v) || ($parsed['base_expr'] == 'CAST')
? " " : ",");
}
return $parsed['base_expr'] . "(" . substr($sql, 0, -1) . ")";
}
Expand Down Expand Up @@ -449,6 +449,8 @@ protected function processSubTree($parsed, $delim = " ") {
$sql .= $this->processConstant($v);
$sql .= $this->processSubQuery($v);
$sql .= $this->processSelectBracketExpression($v);
$sql .= $this->processReserved($v);
$sql .= $this->processColRef($v);

if ($len == strlen($sql)) {
throw new \PHPSQL\Exception\UnableToCreateSQL('expression subtree', $k, $v, 'expr_type');
Expand All @@ -470,6 +472,7 @@ protected function processRefClause($parsed) {
$sql .= $this->processColRef($v);
$sql .= $this->processOperator($v);
$sql .= $this->processConstant($v);
$sql .= $this->processFunction($v);

if ($len == strlen($sql)) {
throw new \PHPSQL\Exception\UnableToCreateSQL('expression ref_clause', $k, $v, 'expr_type');
Expand Down