Skip to content

SWHC009 Supply Fan Controls, Commercial - new measure#92

Draft
simularis wants to merge 13 commits intosound-data:mainfrom
simularis:SWHC009
Draft

SWHC009 Supply Fan Controls, Commercial - new measure#92
simularis wants to merge 13 commits intosound-data:mainfrom
simularis:SWHC009

Conversation

@simularis
Copy link
Copy Markdown
Contributor

@simularis simularis commented Nov 1, 2024

Pull Request (PR) Description

New measure folder "commercial measures/SWHC009-05 Supply Fan Controls"

  • Created new true/false parameter fan_op_fault for fan operation in unitary.pxt and hvac-zone.pxt
  • Default fan schedule is stored in the parameter op_sch. In fault mode, the template overrides the value of the parameter op_sch
  • For calculations, we used the result.py script from Peak demand query tool #65

@afshinfaramarzi was the main contributor.

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • For a new measure, add a summary table showing total energy consumption per simulated case.

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

@nfette
Copy link
Copy Markdown
Contributor

nfette commented Feb 7, 2026

We found additional commits that were not pushed to Github. Changing this PR to "draft" status.

@simularis simularis marked this pull request as draft February 7, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants