Skip to content

SWHC004 Space Heating Boiler (commercial models) - new measure#91

Open
simularis wants to merge 28 commits intosound-data:mainfrom
simularis:SWHC004-com-submission1
Open

SWHC004 Space Heating Boiler (commercial models) - new measure#91
simularis wants to merge 28 commits intosound-data:mainfrom
simularis:SWHC004-com-submission1

Conversation

@simularis
Copy link
Copy Markdown
Contributor

Pull Request (PR) Description

This pull request includes a measure setup for SWHC004. For this measure, we have made the following setup:

  • Adding a new parameter (fluid_type) to implement steam boiler options (hw.pxt)
  • Adding a new parameter (boiler_duplicate_1) to trigger steam boiler type configurations (hw.pxt)
  • Adding new parameter (max_loop_temp) to determine maximum loop temperature for the plant loop (hw.pxt)
  • Adding new parameter (min_loop_temp) to determine minimum loop temperature for the plant loop (hw.pxt)
  • Adding new label “STEAMBOILER” for the parameter (heating_source) to add class list “Boiler:Steam” (hw.pxt)
  • Adding new label “VARIABLESPEEDCONDENSATE” for the parameter (pump_type) to add class list “Pump:VariableSpeed:Condensate” for the steam boiler (hw.pxt)
  • Adding class list “Boiler: Steam” to add steam boiler (hw.pxt)
  • Adding class list “Pipe: Adiabatic: Steam” and its corresponding branches (hw.pxt)
  • Adding “Heating Coil Controller” for steam heat coil type (ahu.pxt)
  • Adding branches for (reheat_coil_type == “STEAM”) (atu.pxt)
  • Adding label "STEAM" for parameter (reheat_coil_type) in class list “AirTerminal:SingleDuct:VAV:Reheat” (atu.pxt)

Main contributor: @behzadsalimian

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • For a new measure, add a summary table showing total energy consumption per simulated case.

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

simularis and others added 28 commits March 21, 2024 15:17
* Condensing boiler requires new parameters for plant loop temperature limits
* Steam boiler requires new parameters for fluid type and steam coils
* Implement heat_coil_type = steam
* Pass new parameters through to ECC, ESe, EUn, HSp, Htl, MBT, Nrs, OfL, Rt3

Original Author: Behzad Salimian Rizi 2024-01-08 through 2024-02-14
* Revert new parameter boiler_duplicate_1 and replace with combination of other parameters
* Clarify new option for pump_type
* Add author comments
Original author: Behzad Rizi, 2024-01-08 through 2024-01-30
SWHC004-Com-Revised OA reset temperature
@nfette
Copy link
Copy Markdown
Contributor

nfette commented Apr 4, 2026

I'm reviewing which comments from #37 apply to this PR. Regarding :hw_boiler_duplicate_1 appearing in cases files, I'm surprised because we addressed that at some point in the past, yet we still see it here.

While reviewing commit history, I see changes that were not clearly described in the commit description.

Commit 4998f6f was described as a renaming, but it also made these changes:

  • Reverted an earlier change at 3dfdec3 to remove parameter :hw_boiler_duplicate_1 from cases files.
  • Added parameter :alt_atu_reheat_coil_type to cases files (in some cohorts)
  • Added parameter :alt_heat_coil_type to cases files (in some cohorts)
  • Removed NG-SpaceHtg_eq-Boiler-NonCond-TE-82
  • Removed NG-SpaceHtg_eq-Boiler-NonCond-TE-83
  • Added NG-SpaceHtg_eq-Boiler-Cond-93-TE-OAT (removed later at 1ba347c)
  • Added NG-SpaceHtg_eq-Boiler-Cond-94-TE-OAT (removed later at 1ba347c)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants