SWHC004 Space Heating Boiler (commercial models) - new measure#91
Open
simularis wants to merge 28 commits intosound-data:mainfrom
Open
SWHC004 Space Heating Boiler (commercial models) - new measure#91simularis wants to merge 28 commits intosound-data:mainfrom
simularis wants to merge 28 commits intosound-data:mainfrom
Conversation
* Condensing boiler requires new parameters for plant loop temperature limits * Steam boiler requires new parameters for fluid type and steam coils * Implement heat_coil_type = steam * Pass new parameters through to ECC, ESe, EUn, HSp, Htl, MBT, Nrs, OfL, Rt3 Original Author: Behzad Salimian Rizi 2024-01-08 through 2024-02-14
* Revert new parameter boiler_duplicate_1 and replace with combination of other parameters * Clarify new option for pump_type * Add author comments
…EnergyPlus.git into dev-com-boiler-variants-2
Original author: Behzad Rizi, 2024-01-08 through 2024-01-30
…rnate atu reheat coil type
SWHC004-Com-Revised OA reset temperature
12 tasks
Contributor
|
I'm reviewing which comments from #37 apply to this PR. Regarding While reviewing commit history, I see changes that were not clearly described in the commit description. Commit 4998f6f was described as a renaming, but it also made these changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Description
This pull request includes a measure setup for SWHC004. For this measure, we have made the following setup:
Main contributor: @behzadsalimian
PR Author
PR Reviewer