-
Notifications
You must be signed in to change notification settings - Fork 15
Develop commercial HVAC boiler variants [feature] #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simularis
wants to merge
12
commits into
sound-data:main
Choose a base branch
from
simularis:dev-com-boiler-variants-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7216557
Modify commercial prototypes for boiler variants
simularis b65f100
Revert change of default setpoint_type
simularis a02a948
Code clean up
simularis 307879d
Duplicate files (batch script)
simularis fa41735
Restore duplicated files (batch script)
simularis 98f2df2
Merge duplicated files (batch script)
simularis f0914e6
Demo parameter inputs for boiler variants
simularis 92cbfe9
Merge branch 'main' of https://github.com/sound-data/DEER-Prototypes-…
simularis 1b8661d
Merge branch 'main' into dev-com-boiler-variants-1
simularis 50209c7
Update to latest vintage convention for boiler variant examples
simularis 1bbe0ea
Adjusted the OAT reset temperature in the template
behzadsalimian e0e140d
Added reheat coil name for atu reheat coil type of RESISTANCE
behzadsalimian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
|
|
||
| # Paths are expanded relative to this modelkit-config file. | ||
|
|
||
| prototypes-dir = '../../prototypes' | ||
| templates-dir = '../../templates/energyplus/templates' | ||
| weather-dir = '../../weather' | ||
| codes-dir = '../../codes' | ||
|
|
||
| max-workers = 12 # Maximum number of simulations to run in parallel | ||
|
|
||
|
|
||
| [template-compose] | ||
| annotate = true | ||
| indent = " " | ||
| esc-line = "! " | ||
| dirs = '~\Documents\Modelkit Caboodle\templates\energyplus\templates' # Must be an absolute path | ||
|
|
||
| [energyplus-run] | ||
| engine = 'C:\EnergyPlusV22-2-0' # Must be an absolute path | ||
| #engine = '/Applications/EnergyPlus-22-2-0' # Must be an absolute path | ||
| #engine = '/Applications/EnergyPlus-9-2-0' # Must be an absolute path | ||
| readvars = true | ||
| keep = false | ||
| output-files = "eplusout.err; eplusout.sql; eplustbl.htm; eplusvar.csv" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| skip,case_name,:hw_heating_source,:hw_fluid_type,:hw_boiler_duplicate_1,:main_atu_reheat_coil_type,:hw_pump_type,:hw_boiler_eff,:hw_boiler_type,:hw_setpoint_type,:main_heat_coil_type,:kitch_heat_coil_type,:hw_supply_temp_at_lo,:hw_supply_temp_at_hi,:hw_max_loop_temp,:hw_min_loop_temp | ||
| ,Boiler_Non-Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.84,NONCONDENSING,Reset,WATER,WATER,73.88,60,100,10 | ||
| ,Boiler_Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.93,CONDENSING,Reset,WATER,WATER,60,46.11,100,10 | ||
| ,Boiler_Steam,STEAMBOILER,STEAM,FALSE,STEAM,VARIABLESPEEDCONDENSATE,0.81,,Reset,STEAM,STEAM,73.88,60,120,10 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| skip,case_name,:hw_heating_source,:hw_fluid_type,:hw_boiler_duplicate_1,:main_atu_reheat_coil_type,:hw_pump_type,:hw_boiler_eff,:hw_boiler_type,:hw_setpoint_type,:main_heat_coil_type,:kitch_heat_coil_type,:hw_supply_temp_at_lo,:hw_supply_temp_at_hi,:hw_max_loop_temp,:hw_min_loop_temp | ||
| ,Boiler_Non-Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.84,NONCONDENSING,Reset,WATER,WATER,73.88,60,100,10 | ||
| ,Boiler_Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.93,CONDENSING,Reset,WATER,WATER,60,46.11,100,10 | ||
| ,Boiler_Steam,STEAMBOILER,STEAM,FALSE,STEAM,VARIABLESPEEDCONDENSATE,0.81,,Reset,STEAM,STEAM,73.88,60,120,10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| skip,case_name,:hw_heating_source,:hw_fluid_type,:hw_boiler_duplicate_1,:main_atu_reheat_coil_type,:hw_pump_type,:hw_boiler_eff,:hw_boiler_type,:hw_setpoint_type,:main_heat_coil_type,:kitch_heat_coil_type,:hw_supply_temp_at_lo,:hw_supply_temp_at_hi,:hw_max_loop_temp,:hw_min_loop_temp | ||
| ,Boiler_Non-Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.84,NONCONDENSING,Reset,WATER,WATER,73.88,60,100,10 | ||
| ,Boiler_Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.93,CONDENSING,Reset,WATER,WATER,60,46.11,100,10 | ||
| ,Boiler_Steam,STEAMBOILER,STEAM,FALSE,STEAM,VARIABLESPEEDCONDENSATE,0.81,,Reset,STEAM,STEAM,73.88,60,120,10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| skip,case_name,:hw_heating_source,:hw_fluid_type,:hw_boiler_duplicate_1,:main_atu_reheat_coil_type,:hw_pump_type,:hw_boiler_eff,:hw_boiler_type,:hw_setpoint_type,:main_heat_coil_type,:kitch_heat_coil_type,:hw_supply_temp_at_lo,:hw_supply_temp_at_hi,:hw_max_loop_temp,:hw_min_loop_temp | ||
| ,Boiler_Non-Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.84,NONCONDENSING,Reset,WATER,WATER,73.88,60,100,10 | ||
| ,Boiler_Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.93,CONDENSING,Reset,WATER,WATER,60,46.11,100,10 | ||
| ,Boiler_Steam,STEAMBOILER,STEAM,FALSE,STEAM,VARIABLESPEEDCONDENSATE,0.81,,Reset,STEAM,STEAM,73.88,60,120,10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| skip,case_name,:hw_heating_source,:hw_fluid_type,:hw_boiler_duplicate_1,:main_atu_reheat_coil_type,:hw_pump_type,:hw_boiler_eff,:hw_boiler_type,:hw_setpoint_type,:main_heat_coil_type,:kitch_heat_coil_type,:hw_supply_temp_at_lo,:hw_supply_temp_at_hi,:hw_max_loop_temp,:hw_min_loop_temp | ||
| ,Boiler_Non-Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.84,NONCONDENSING,Reset,WATER,WATER,73.88,60,100,10 | ||
| ,Boiler_Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.93,CONDENSING,Reset,WATER,WATER,60,46.11,100,10 | ||
| ,Boiler_Steam,STEAMBOILER,STEAM,FALSE,STEAM,VARIABLESPEEDCONDENSATE,0.81,,Reset,STEAM,STEAM,73.88,60,120,10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| skip,case_name,:hw_heating_source,:hw_fluid_type,:hw_boiler_duplicate_1,:main_atu_reheat_coil_type,:hw_pump_type,:hw_boiler_eff,:hw_boiler_type,:hw_setpoint_type,:main_heat_coil_type,:kitch_heat_coil_type,:hw_supply_temp_at_lo,:hw_supply_temp_at_hi,:hw_max_loop_temp,:hw_min_loop_temp | ||
| ,Boiler_Non-Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.84,NONCONDENSING,Reset,WATER,WATER,73.88,60,100,10 | ||
| ,Boiler_Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.93,CONDENSING,Reset,WATER,WATER,60,46.11,100,10 | ||
| ,Boiler_Steam,STEAMBOILER,STEAM,FALSE,STEAM,VARIABLESPEEDCONDENSATE,0.81,,Reset,STEAM,STEAM,73.88,60,120,10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| skip,case_name,:hw_heating_source,:hw_fluid_type,:hw_boiler_duplicate_1,:main_atu_reheat_coil_type,:hw_pump_type,:hw_boiler_eff,:hw_boiler_type,:hw_setpoint_type,:main_heat_coil_type,:kitch_heat_coil_type,:hw_supply_temp_at_lo,:hw_supply_temp_at_hi,:hw_max_loop_temp,:hw_min_loop_temp | ||
| ,Boiler_Non-Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.84,NONCONDENSING,Reset,WATER,WATER,73.88,60,100,10 | ||
| ,Boiler_Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.93,CONDENSING,Reset,WATER,WATER,60,46.11,100,10 | ||
| ,Boiler_Steam,STEAMBOILER,STEAM,FALSE,STEAM,VARIABLESPEEDCONDENSATE,0.81,,Reset,STEAM,STEAM,73.88,60,120,10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| skip,case_name,:hw_heating_source,:hw_fluid_type,:hw_boiler_duplicate_1,:main_atu_reheat_coil_type,:hw_pump_type,:hw_boiler_eff,:hw_boiler_type,:hw_setpoint_type,:main_heat_coil_type,:kitch_heat_coil_type,:hw_supply_temp_at_lo,:hw_supply_temp_at_hi,:hw_max_loop_temp,:hw_min_loop_temp | ||
| ,Boiler_Non-Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.84,NONCONDENSING,Reset,WATER,WATER,73.88,60,100,10 | ||
| ,Boiler_Condensing,BOILER,WATER,TRUE,WATER,VARIABLE,0.93,CONDENSING,Reset,WATER,WATER,60,46.11,100,10 | ||
| ,Boiler_Steam,STEAMBOILER,STEAM,FALSE,STEAM,VARIABLESPEEDCONDENSATE,0.81,,Reset,STEAM,STEAM,73.88,60,120,10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| skip,climate,weather_file,climate_zone,codes_file | ||
| ,CZ01,CA_EUREKA_725940S_CZ2022.epw,1,T24_weight_averaged_ex.csv | ||
| ,CZ02,CA_NAPA-CO_724955S_CZ2022.epw,2,T24_weight_averaged_ex.csv | ||
| ,CZ03,CA_OAKLAND-METRO-AP_724930S_CZ2022.epw,3,T24_weight_averaged_ex.csv | ||
| ,CZ04,CA_SAN-JOSE-IAP_724945S_CZ2022.epw,4,T24_weight_averaged_ex.csv | ||
| ,CZ05,CA_SANTA-MARIA-PUBLIC-AP_723940S_CZ2022.epw,5,T24_weight_averaged_ex.csv | ||
| ,CZ06,CA_LOS-ANGELES-IAP_722950S_CZ2022.epw,6,T24_weight_averaged_ex.csv | ||
| ,CZ07,CA_SAN-DIEGO-LINDBERGH-FLD_722900S_CZ2022.epw,7,T24_weight_averaged_ex.csv | ||
| ,CZ08,CA_LONG-BEACH-DAUGHERTY-FLD_722970S_CZ2022.epw,8,T24_weight_averaged_ex.csv | ||
| ,CZ09,CA_LOS-ANGELES-DOWNTOWN-USC_722874S_CZ2022.epw,9,T24_weight_averaged_ex.csv | ||
| ,CZ10,CA_RIVERSIDE-MUNI_722869S_CZ2022.epw,10,T24_weight_averaged_ex.csv | ||
| ,CZ11,CA_RED-BLUFF-MUNI-AP_725910S_CZ2022.epw,11,T24_weight_averaged_ex.csv | ||
| ,CZ12,CA_STOCKTON-METRO-AP_724920S_CZ2022.epw,12,T24_weight_averaged_ex.csv | ||
| ,CZ13,CA_FRESNO-YOSEMITE-IAP_723890S_CZ2022.epw,13,T24_weight_averaged_ex.csv | ||
| ,CZ14,CA_DAGGETT-BARSTOW-AP_723815S_CZ2022.epw,14,T24_weight_averaged_ex.csv | ||
| ,CZ15,CA_EL-CENTRO-NAF_722810S_CZ2022.epw,15,T24_weight_averaged_ex.csv | ||
| ,CZ16,CA_BISHOP-AP_724800S_CZ2022.epw,16,T24_weight_averaged_ex.csv |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the parameter
hw_boiler_duplicate_1must behw_boiler_duplicate. Otherwise,hw_boiler_duplicatewill remain equal to default. Modelkit doesn't seem to output an error when an undefined parameter is specified incasesfolder.