Skip to content

Parameterized residential prototypes with sizing and unmet hours fixes#156

Open
Justin-DeBlois wants to merge 9 commits intosound-data:mainfrom
TRC-RTC:Res-Dev-Alternative-Residential-Prototypes
Open

Parameterized residential prototypes with sizing and unmet hours fixes#156
Justin-DeBlois wants to merge 9 commits intosound-data:mainfrom
TRC-RTC:Res-Dev-Alternative-Residential-Prototypes

Conversation

@Justin-DeBlois
Copy link
Copy Markdown
Contributor

Parameterized residential prototypes with sizing and unmet hours fixes

Pull Request (PR) Description

This pull request builds off of the SWWH037-01 Heat Pump Combined Space and DHW with TES work (#110), which creates simplified residential prototype root files with HVAC and DHW templates to make it possible to model more configurations.

Additional changes have been made and discussed with the eTRM HVAC/Water Heating SME Collaboration Meeting:

  • Revised design day internal gains schedules.
  • Revised design day temperature setpoint schedules.
  • Revised thermostat objects for design day and simulation year.
  • Revised sizing run options

The results showed reduced unmet hours, bringing most models to <300 total. In addition, autosized cooling capacities increased to be closer to field data on installed units. Autosized heating capacities increased but remain lower than field data, possibly explained by overly conservative sizing approaches used in the field.

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • For a new measure, add a summary table showing total energy consumption per simulated case.

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

@rogerkbaker
Copy link
Copy Markdown
Contributor

I reviewed this work previously and see no issues with it.

@sepideh-QEA
Copy link
Copy Markdown
Collaborator

@Justin-DeBlois — This PR doesn’t merge cleanly into current sound-data/main. Git reports conflicts on 13 paths where both main and this branch have different versions of the same files: all 10 combi templates/root.pxt under prototypes/residential/ and the 3 shared templates res-zone-hvac-combi.pxt, res-hw-system-combi.pxt, and res-water-heater-combi.pxt under templates/energyplus/templates/.
Those combi paths already exist on main today; this PR updates them again with divergent content (e.g. sizing parameters, SimulationControl / sizing flags, mains water Schedule:File path style, CDD schedule handling, etc.), so they need an explicit merge/rebase resolution.
Could you merge or rebase sound-data/main into this branch, resolve those 13 files, and push to Res-Dev-Alternative-Residential-Prototypes? I don’t have push access to the head branch, so I can’t use GitHub’s conflict UI to finish it from here.
Thanks!

@Justin-DeBlois
Copy link
Copy Markdown
Contributor Author

@sepideh-QEA I merged the branches- all conflicts should be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants