Skip to content

Fix design day schedules for non-residential prototypes#153

Open
rogerkbaker wants to merge 2 commits intosound-data:mainfrom
rogerkbaker:Fix_DD_Schedules
Open

Fix design day schedules for non-residential prototypes#153
rogerkbaker wants to merge 2 commits intosound-data:mainfrom
rogerkbaker:Fix_DD_Schedules

Conversation

@rogerkbaker
Copy link
Copy Markdown
Contributor

Pull Request (PR) Description

This Pull Request incorporates Cooling and Heating Design Day schedules, as recommended by ASHRAE 90.1 Appendix G. The changes touch all 26 root files. Lighting, Equipment and Occupancy schedules are amended to include Cooling Design Day (fractional value of 1.0 for all 24 hours of day) and Heating Design Day (fractional value of 0.0 for all hours of day), plus design day HVAC schedules that are based on most commonly used profile for both cooling and heating.

This Request is intended to be for all new measures modeled as part of the 2028 cycle.

DEER Support Email: DeerSupport@guidehouse.com

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • For a new measure, add a summary table showing total energy consumption per simulated case.

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

rogerkbaker and others added 2 commits December 14, 2025 17:11
Prototype root.pxt files are updated to reflect ASHRAE 90.1 Appendix G schedule guidance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant