Skip to content

SWHC024 revision to address review comments and recent guidance#134

Open
simularis wants to merge 8 commits intosound-data:mainfrom
simularis:SWHC024-06-cpuc-review
Open

SWHC024 revision to address review comments and recent guidance#134
simularis wants to merge 8 commits intosound-data:mainfrom
simularis:SWHC024-06-cpuc-review

Conversation

@simularis
Copy link
Copy Markdown
Contributor

Pull Request (PR) Description

SWHC024 revision to address review comments and recent guidance

  • Revert prior change to expose fan_eff in kitch and crac HVAC groups (CPUC reviewer)
  • Update sizing factors to 1.15/1.25 matching ASHRAE standard approach (SCE)
  • Update cooling capacity process: sizing query file using AirLoopHVAC:UnitarySystem, coil_list.xlsx, and result_filtered.py

These changes were made around November 17 and shared via "internal review" pull request, simularis#43, just not transferred to the official pull request #106 prior to merging.

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • For a new measure, add a summary table showing total energy consumption per simulated case.

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants