Skip to content

SWHC044 & SWHC045 Baseline Updates – Hydronic Heating#130

Merged
sepideh-QEA merged 30 commits intosound-data:mainfrom
simularis:solaris-HVAC-rDXHW-v2
Mar 26, 2026
Merged

SWHC044 & SWHC045 Baseline Updates – Hydronic Heating#130
sepideh-QEA merged 30 commits intosound-data:mainfrom
simularis:solaris-HVAC-rDXHW-v2

Conversation

@behzadsalimian
Copy link
Copy Markdown
Contributor

Pull Request (PR) Description

Overview

This pull request adds additional baseline cases for SWHC044 and SWHC045, incorporating hydronic heating via radiator or fan coil as a baseline case for multifamily buildings. The hydronic cases now leverage the templatized residential prototypes provided by TRC in sound-data#110.

Main Contributor Email: brizi@solaris-technical.com

Summary of Changes

  • Test Runs: TRC prototypes tested using HP Combi folder
  • Baseline Changes: Applied baseboard radiator object (ZoneHVAC:Baseboard:Convective:Water) to templates (res-zone-hvac-combi.pxt)
  • New Parameter: sub_heat_type added to templates; logic implemented for BASEBOARD-WATER.
  • HVAC Logic: Updated branches/branch lists; added hot water fan coil (hydronic air handler) setup and sequencing.
  • Heating Source: Parametrized boiler efficiency, boiler efficiency curve and efficiency curve temperature evaluation variable to switch between condensing and non-condensing boiler type.
  • Measure Updates: Transitioned model setup for SWHC045 from SWHC049 folder (which used the individual building type and HVAC type specific prototypes) and SWHC044 from SWHC050 folder. All the techIDs required to reproduce SWHC044 and SWHC045 base case or measure case models were defined as cases in these new folders using the templatized residential prototypes.
  • Secondary Zone Handling: Radiator as a zone equipment was assigned to secondary zones and all the nodes, branch connections and equipment sequencing (ZoneHVAC:EquipmentList) were developed accordingly.
  • Documentation: README added to describe workarounds and reproduce results.

Key Assumptions (SWHC044)

  • Gravity Wall Furnace
    o Infinite fan efficiency used to achieve zero fan power; EnergyPlus limits efficiency ≤1.
    o Alternative: setting fan pressure = 0 achieves same result.
  • Window AC
    o EER assumed 11, representing mid-range (0–7,999 Btu/h) residential units.
    o Converted to COP (cooling) = 3.72.

Pull request review checklists

Repository Owner

  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
    • New Measure
  • Assign a reviewer.

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
    • See eTRM (SWHC044 & SWHC045)
  • For a new measure, add a summary table showing total energy consumption per simulated case.
    • See eTRM (SWHC044 & SWHC045)

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

Justin-DeBlois and others added 28 commits May 12, 2025 17:10
Extracted changes to templates from original commit by Justin DeBlois:
Original commit 3699fd7 on 2025-05-14
Combi HP measure - Adjust DHW setpoint control in cases file and fix template paths
…ation variable" and "boiler efficiency curve"
Develop HVAC baselines rDXHW using updated prototypes
- Develop rDXHW hydronic radiator (boiler, hot water, no fan) baseline in MFm-1985-combi prototypes and templates
- Extend parameterized options for rDXHW hydronic fan coil (boiler, hot water, fan coil) baseline in MFm-1985-combi prototypes and templates
- Transition SWHC045 definitions from SWHC049 plus new baselines
- Transition SWHC044 definitions from SWHC050 plus new baselines
- Initial testing and QC
Copy link
Copy Markdown
Contributor

@nfette nfette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to add a TechID at 80 AFUE bypassed internal review. Please see comments.

Comment on lines +8 to +13
#,RE-dxHP_equip-pkgSEER-15.2-SEER2-7.7-HSPF2,DX,,,,,,,,4.11,4.05,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
#,RE-dxHP_equip-pkgSEER-16.0-SEER2-8.0-HSPF2,DX,,,,,,,,4.22,4.11,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
#,RE-dxHP_equip-pkgSEER-16.9-SEER2-8.1-HSPF2,DX,,,,,,,,4.33,4.13,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
#,RE-dxHP_equip-pkgSEER-17.8-SEER2-8.1-HSPF2,DX,,,,,,,,4.43,4.13,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
#,RE-dxHP_equip-pkgSEER-18.7-SEER2-8.5-HSPF2,DX,,,,,,,,4.51,4.19,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
#,RE-dxHP_equip-pkgSEER-19.6-SEER2-8.9-HSPF2,DX,,,,,,,,4.58,4.24,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment these rows if they are still used in measure savings. I assume this was just a temporary change to avoid re-running those models.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncommented.

Comment on lines +8 to +13
#,RE-dxHP_equip-pkgSEER-15.2-SEER2-7.7-HSPF2,DX,,,,,,,,4.11,4.05,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
#,RE-dxHP_equip-pkgSEER-16.0-SEER2-8.0-HSPF2,DX,,,,,,,,4.22,4.11,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
#,RE-dxHP_equip-pkgSEER-16.9-SEER2-8.1-HSPF2,DX,,,,,,,,4.33,4.13,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
#,RE-dxHP_equip-pkgSEER-17.8-SEER2-8.1-HSPF2,DX,,,,,,,,4.43,4.13,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
#,RE-dxHP_equip-pkgSEER-18.7-SEER2-8.5-HSPF2,DX,,,,,,,,4.51,4.19,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
#,RE-dxHP_equip-pkgSEER-19.6-SEER2-8.9-HSPF2,DX,,,,,,,,4.58,4.24,0.25,0.5,,FALSE,TRUE,VFD_Fan_Curve,multispeed,unitary_system,,,,,,,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment these rows

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncommented.

@nfette
Copy link
Copy Markdown
Contributor

nfette commented Mar 26, 2026

Should we rename the measure folders to include measure version?

git mv "residential measures/SWHC044 Ductless HVAC Fuel Sub" "residential measures/SWHC044-07 Ductless HVAC Fuel Sub"
git mv "residential measures/SWHC045 Heat Pump HVAC Fuel Sub" "residential measures/SWHC045-06 Heat Pump HVAC Fuel Sub"

@sepideh-QEA sepideh-QEA merged commit bd97c90 into sound-data:main Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants