Skip to content

SWHC005 Update following 2025 Title 24 codes file update#108

Open
simularis wants to merge 42 commits intosound-data:mainfrom
simularis:SWHC005-T24-update
Open

SWHC005 Update following 2025 Title 24 codes file update#108
simularis wants to merge 42 commits intosound-data:mainfrom
simularis:SWHC005-T24-update

Conversation

@simularis
Copy link
Copy Markdown
Contributor

@simularis simularis commented May 2, 2025

Pull Request (PR) Description

This pull request includes commits from and supersedes #72. Cumulative setup description:

  • Measure setup for water cooled chillers in measure folder "commercial measures/SWHC020-05 Air Cooled Chiller"

Initial work (2024)

  • Added water-cooled chiller performance curve definitions from Energy Solutions research and from EnergyPlus library file "chiller.idf".
  • Added new parameter (chw_)wc_option to allow switching water-cooled chiller object type from Chiller:Electric:ReformulatedEIR to Chiller:Electric:EIR (in the chw.pxt template).
  • Added new parameter (chw_)chiller_eir_fplr_type to support Lift type EIR curve as a function of PLR. Initially, we do not propose linking this to chiller_model (in chw.pxt).
  • Introduced query file for collecting data for IPLV and chiller cooling capacity (query_wcc.txt).
  • Measure setup for chillers reflects distinct offerings varying by chiller type, capacity, and tier since code requirements vary by chiller type and capacity.

Revisions (2025)

  • Apply 2025 Title 24 updates to SWHC005.
  • Tech runs for screw type chiller are defined but skipped for simulation.

Performance curves proposed to add to chw.pxt

Measure case performance curve candidates

  • "Model 9 WC Chiller" (ReformEIRChiller type, EIR_fPLR curve type = Lift, curves provided by email Energy Solutions)
  • "Model 7 WC Chiller" (ReformEIRChiller type, EIR_fPLR curve type = Lift, curves provided by email Energy Solutions)
    Base case performance curve candidates from EnergyPlus dataset chillers.idf
  • Added "WC Cent Carrier 19XR 1234kW/5.39COP/VSD" (ElectricEIRChiller type)
  • Added "WC Trane RTHB 1051kW/5.05COP/Valve" (ElectricEIRChiller type)
  • Added "ReformEIRChiller WC Cent Carrier 19XR 1234kW/5.39COP/VSD" (ReformEIRChiller type)
  • Added "ReformEIRChiller Screw WC Carrier 23XL 1062kW/5.50COP/Valve" (ReformEIRChiller type)

Measure developer internal review

Solaris Technical team conducted internal PR review at simularis#22.

Internal review unresolved comments, critical

  • None

Internal review unresolved comments, wishlist

  • Model setup for screw type chiller not included in this submission

PR Review Checklist

PR Owner

  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
    • New Measure
  • Assign a reviewer.

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
    • See eTRM
  • For a new measure, add a summary table showing total energy consumption per simulated case.
    • See eTRM

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

simularis and others added 30 commits July 29, 2024 19:37
* Put original behavior in ELSE clause (Chiller:Electric:ReformulatedEIR)
* Add descriptive comments after ELSE and END tags
simularis and others added 8 commits May 2, 2025 18:01
Develop SWHC005 Title 24 Update

This pull request includes commits from and supersedes sound-data#72. Cumulative setup description:

- Measure setup for water cooled chillers in measure folder "commercial measures/SWHC020-06 Air Cooled Chiller"
Initial work (2024)
- Added water-cooled chiller performance curve definitions from Energy Solutions research and from EnergyPlus library file "[chiller.idf](https://github.com/NREL/EnergyPlus/tree/develop/datasets)".
- Added new parameter `(chw_)wc_option` to allow switching water-cooled chiller object type from Chiller:Electric:ReformulatedEIR to Chiller:Electric:EIR (in the `chw.pxt` template).
- Added new parameter `(chw_)chiller_eir_fplr_type` to support Lift type EIR curve as a function of PLR. Initially, we do not propose linking this to chiller_model (in chw.pxt).
- Introduced query file for collecting data for IPLV and chiller cooling capacity (query_wcc.txt).
- Measure setup for chillers reflects distinct offerings varying by chiller type, capacity, and tier since code requirements vary by chiller type and capacity.

Revisions (2025)
- Apply 2025 Title 24 updates to SWHC005.
- Tech runs for screw type chiller are defined but skipped for simulation.

### Performance curves proposed to add to chw.pxt

Measure case performance curve candidates
- "Model 9 WC Chiller" (ReformEIRChiller type, EIR_fPLR curve type = Lift, curves provided by email Energy Solutions)
- "Model 7 WC Chiller" (ReformEIRChiller type, EIR_fPLR curve type = Lift, curves provided by email Energy Solutions)
Base case performance curve candidates from EnergyPlus dataset chillers.idf
- Added "WC Cent Carrier 19XR 1234kW/5.39COP/VSD" (ElectricEIRChiller type)
- Added "WC Trane RTHB 1051kW/5.05COP/Valve" (ElectricEIRChiller type)
- Added "ReformEIRChiller WC Cent Carrier 19XR 1234kW/5.39COP/VSD" (ReformEIRChiller type)
- Added "ReformEIRChiller Screw WC Carrier 23XL 1062kW/5.50COP/Valve" (ReformEIRChiller type)

### Internal review unresolved comments, critical
- None

### Internal review unresolved comments, wishlist
- Model setup for screw type chiller not included in this submission
behzadsalimian and others added 4 commits September 18, 2025 10:13
Added chiller performance curves for tier 1 and tier 2
Iterate on SWHC005 Water Cooled Chiller

- Clarify R ratio in TechIDs
- Propose new chiller models representative of COP/IPLV efficiency tiers
- Parameterize minimum part load ratio and unloading ratio
- Revise minimum part load ratio and unloading ratio inputs for SWHC005 cases
- Specify PLR curve reference temperatures (chw_temp_ref) for each case (resolves mismatched reference temperatures when using defaults only)
- Implement linked-sizing so that measure case instances use exact sizing data from base case instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants