SWHC005 Update following 2025 Title 24 codes file update#108
Open
simularis wants to merge 42 commits intosound-data:mainfrom
Open
SWHC005 Update following 2025 Title 24 codes file update#108simularis wants to merge 42 commits intosound-data:mainfrom
simularis wants to merge 42 commits intosound-data:mainfrom
Conversation
…atible with Com.py)
* Put original behavior in ELSE clause (Chiller:Electric:ReformulatedEIR) * Add descriptive comments after ELSE and END tags
…ler:Electric:ReformulatedEIR)
…ve to chiller_eir_fplr_type)
…ipt" This reverts commit e5303e8.
Develop SWHC005 Title 24 Update This pull request includes commits from and supersedes sound-data#72. Cumulative setup description: - Measure setup for water cooled chillers in measure folder "commercial measures/SWHC020-06 Air Cooled Chiller" Initial work (2024) - Added water-cooled chiller performance curve definitions from Energy Solutions research and from EnergyPlus library file "[chiller.idf](https://github.com/NREL/EnergyPlus/tree/develop/datasets)". - Added new parameter `(chw_)wc_option` to allow switching water-cooled chiller object type from Chiller:Electric:ReformulatedEIR to Chiller:Electric:EIR (in the `chw.pxt` template). - Added new parameter `(chw_)chiller_eir_fplr_type` to support Lift type EIR curve as a function of PLR. Initially, we do not propose linking this to chiller_model (in chw.pxt). - Introduced query file for collecting data for IPLV and chiller cooling capacity (query_wcc.txt). - Measure setup for chillers reflects distinct offerings varying by chiller type, capacity, and tier since code requirements vary by chiller type and capacity. Revisions (2025) - Apply 2025 Title 24 updates to SWHC005. - Tech runs for screw type chiller are defined but skipped for simulation. ### Performance curves proposed to add to chw.pxt Measure case performance curve candidates - "Model 9 WC Chiller" (ReformEIRChiller type, EIR_fPLR curve type = Lift, curves provided by email Energy Solutions) - "Model 7 WC Chiller" (ReformEIRChiller type, EIR_fPLR curve type = Lift, curves provided by email Energy Solutions) Base case performance curve candidates from EnergyPlus dataset chillers.idf - Added "WC Cent Carrier 19XR 1234kW/5.39COP/VSD" (ElectricEIRChiller type) - Added "WC Trane RTHB 1051kW/5.05COP/Valve" (ElectricEIRChiller type) - Added "ReformEIRChiller WC Cent Carrier 19XR 1234kW/5.39COP/VSD" (ReformEIRChiller type) - Added "ReformEIRChiller Screw WC Carrier 23XL 1062kW/5.50COP/Valve" (ReformEIRChiller type) ### Internal review unresolved comments, critical - None ### Internal review unresolved comments, wishlist - Model setup for screw type chiller not included in this submission
13 tasks
Added chiller performance curves for tier 1 and tier 2
Iterate on SWHC005 Water Cooled Chiller - Clarify R ratio in TechIDs - Propose new chiller models representative of COP/IPLV efficiency tiers - Parameterize minimum part load ratio and unloading ratio - Revise minimum part load ratio and unloading ratio inputs for SWHC005 cases - Specify PLR curve reference temperatures (chw_temp_ref) for each case (resolves mismatched reference temperatures when using defaults only) - Implement linked-sizing so that measure case instances use exact sizing data from base case instances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Description
This pull request includes commits from and supersedes #72. Cumulative setup description:
Initial work (2024)
(chw_)wc_optionto allow switching water-cooled chiller object type from Chiller:Electric:ReformulatedEIR to Chiller:Electric:EIR (in thechw.pxttemplate).(chw_)chiller_eir_fplr_typeto support Lift type EIR curve as a function of PLR. Initially, we do not propose linking this to chiller_model (in chw.pxt).Revisions (2025)
Performance curves proposed to add to chw.pxt
Measure case performance curve candidates
Base case performance curve candidates from EnergyPlus dataset chillers.idf
Measure developer internal review
Solaris Technical team conducted internal PR review at simularis#22.
Internal review unresolved comments, critical
Internal review unresolved comments, wishlist
PR Review Checklist
PR Owner
PR Author
PR Reviewer