Skip to content

SWHC020 update following 2025 Title 24 codes file update#107

Open
simularis wants to merge 25 commits intosound-data:mainfrom
simularis:SWHC020-T24-update
Open

SWHC020 update following 2025 Title 24 codes file update#107
simularis wants to merge 25 commits intosound-data:mainfrom
simularis:SWHC020-T24-update

Conversation

@simularis
Copy link
Copy Markdown
Contributor

@simularis simularis commented Apr 30, 2025

Pull Request (PR) Description

Measure update: SWHC020 Title 24 Update

PR Owner

  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
    • New Measure
  • Assign a reviewer.

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
    • See eTRM
  • For a new measure, add a summary table showing total energy consumption per simulated case.
    • See eTRM

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

Solaris Technical team conducted internal PR review at simularis#21 and simularis#30.

Internal review unresolved comments, critical:

  • None

Internal review unresolved comments, wishlist:

  • None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants