SWHC012 update following 2025 Title 24 codes file update#105
Open
simularis wants to merge 80 commits intosound-data:mainfrom
Open
SWHC012 update following 2025 Title 24 codes file update#105simularis wants to merge 80 commits intosound-data:mainfrom
simularis wants to merge 80 commits intosound-data:mainfrom
Conversation
…rature setpoint schedule
# Conflicts: # prototypes/EPr/templates/root.pxt # prototypes/ESe/templates/root.pxt
This reverts commit 3cf473b. # Conflicts: # commercial measures/SWHC012-05 Occupancy Sensor/result2.py # commercial measures/SWHC012-05 Occupancy Sensor/simdata.csv
…etail.csv" This reverts commit 5c5febc. # Conflicts: # commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_Ex/result.py # commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_Ex/results-sizing-agg.csv # commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_Ex/results-sizing-detail.csv # commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_New/result.py # commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_New/results-sizing-agg.csv # commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_New/results-sizing-detail.csv
SWHC012 Occ Schedule Script Updates - Revise occupancy fraction in prototypes schedule based on NREL occupancy fractions combined with school term dates from prototypes EPr, ESe, and ERC - Revise measure case temperature setpoint schedules to align with occupancy schedule - Align schedule timestep with simulation timestep - 10 minutes per item - Revise setpoint setback temperature to be consistent between base case and measure case - After testing linked sizing and workarounds failed, continue to use autosizing for all 3 building types - Update heating and cooling sizing factors to align with ASHRAE guidelines - Clarify how schedule script and Schedule:File together apply the correct daylight saving time adjustment - Clarify how to run simulations with relative file path for temperature setpoint schedules - Consolidate temperature setpoint schedule generator script
…:Cooling:DX:Multispeed
…ith Coil:Cooling:DX:Multispeed" This reverts commit 58cd86e.
Contributor
Author
|
Additional changes are pending closeout of internal review at simularis#45 |
Debug SWCH012 linked sizing and normalizing units. Key changes include: - Enable linked sizing in measure (disable_ems, sizing_case parameters) - Revise normalizing unit process for sizing results with sizing query, coil list, and result_filtered, and describe in README - Create coil list and separate query for sizing results. Additional enabling steps, enhancements, and QC: - Update modelkit sizing map file for EnergyPlus v22-2 based on manual review of EnergyPlus outputs - Workaround to EnergyPlus bug mislabeling output field for multispeed coil Speed 2 capacity - Enhancement: apply workaround for relative path to schedule files SWHC012 - In sizing query, remove queries that produce text results to avoid error - Remove extraneous entry from coil list (ESe Computer Classroom)
Contributor
Author
|
Measure developer finalized all pending changes. This pull request is ready for review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Description
Measure update for SWHC012
Repo Owner
PR Author
PR Reviewer
Internal PR review was conducted by Solaris Technical team at simularis#16, simularis#38, and simularis#45.
Critical comments not yet resolved:
Reviewer wishlist items (not important enough to block merging):