Skip to content

SWHC012 update following 2025 Title 24 codes file update#105

Open
simularis wants to merge 80 commits intosound-data:mainfrom
simularis:SWHC012-T24-update
Open

SWHC012 update following 2025 Title 24 codes file update#105
simularis wants to merge 80 commits intosound-data:mainfrom
simularis:SWHC012-T24-update

Conversation

@simularis
Copy link
Copy Markdown
Contributor

@simularis simularis commented Apr 30, 2025

Pull Request (PR) Description

Measure update for SWHC012

  • Apply 2025 Title 24 updates to SWHC012.
  • Create new measure folder: commercial measures/SWHC012-05 Occupancy Sensor.
  • Enable linked-sizing, including revised modelkit sizing map file for EnergyPlus v22.2.
  • Document and automate normalizing unit calculation
  • Special notes about this measure: this measure requires occupancy schedules. We include a python script to generate an occupancy schedule, save it into a CSV file, and that CSV file is read by EnergyPlus. Schedules were revised during CPUC review.
  • This pull request includes commits from and supersedes SWHC012 HVAC Occupancy Sensor, Classroom - new measure #84.

Repo Owner

  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Assign a reviewer.

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
    • Solaris Technical: We bypass post-processing scripts for this measure, and do not include the measure list workbook.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
    • See eTRM
  • For a new measure, add a summary table showing total energy consumption per simulated case.
    • See eTRM

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

Internal PR review was conducted by Solaris Technical team at simularis#16, simularis#38, and simularis#45.

Critical comments not yet resolved:

  • None

Reviewer wishlist items (not important enough to block merging):

  • SWHC012-04 folder was moved rather than duplicated in commit 067a8dd.

behzadsalimian and others added 30 commits March 27, 2024 01:58
# Conflicts:
#	prototypes/EPr/templates/root.pxt
#	prototypes/ESe/templates/root.pxt
This reverts commit 3cf473b.

# Conflicts:
#	commercial measures/SWHC012-05 Occupancy Sensor/result2.py
#	commercial measures/SWHC012-05 Occupancy Sensor/simdata.csv
…etail.csv"

This reverts commit 5c5febc.

# Conflicts:
#	commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_Ex/result.py
#	commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_Ex/results-sizing-agg.csv
#	commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_Ex/results-sizing-detail.csv
#	commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_New/result.py
#	commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_New/results-sizing-agg.csv
#	commercial measures/SWHC012-05 Occupancy Sensor/SWHC012-05 Occupancy Sensor_New/results-sizing-detail.csv
nfette added 23 commits October 30, 2025 15:49
SWHC012 Occ Schedule Script Updates

- Revise occupancy fraction in prototypes schedule based on NREL occupancy fractions combined with school term dates from prototypes EPr, ESe, and ERC
- Revise measure case temperature setpoint schedules to align with occupancy schedule
- Align schedule timestep with simulation timestep - 10 minutes per item
- Revise setpoint setback temperature to be consistent between base case and measure case
- After testing linked sizing and workarounds failed, continue to use autosizing for all 3 building types
- Update heating and cooling sizing factors to align with ASHRAE guidelines
- Clarify how schedule script and Schedule:File together apply the correct daylight saving time adjustment
- Clarify how to run simulations with relative file path for temperature setpoint schedules
- Consolidate temperature setpoint schedule generator script
…ith Coil:Cooling:DX:Multispeed"

This reverts commit 58cd86e.
@simularis
Copy link
Copy Markdown
Contributor Author

Additional changes are pending closeout of internal review at simularis#45

@simularis simularis marked this pull request as draft December 17, 2025 01:02
nfette and others added 3 commits January 3, 2026 19:05
Debug SWCH012 linked sizing and normalizing units. Key changes include:

- Enable linked sizing in measure (disable_ems, sizing_case parameters)
- Revise normalizing unit process for sizing results with sizing query, coil list, and result_filtered, and describe in README
- Create coil list and separate query for sizing results.

Additional enabling steps, enhancements, and QC:

- Update modelkit sizing map file for EnergyPlus v22-2 based on manual review of EnergyPlus outputs
- Workaround to EnergyPlus bug mislabeling output field for multispeed coil Speed 2 capacity
- Enhancement: apply workaround for relative path to schedule files SWHC012
- In sizing query, remove queries that produce text results to avoid error
- Remove extraneous entry from coil list (ESe Computer Classroom)
@simularis
Copy link
Copy Markdown
Contributor Author

Measure developer finalized all pending changes. This pull request is ready for review and merge.

@simularis simularis marked this pull request as ready for review January 4, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants